Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache): only return validated stale value #1795

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(cache): only return validated stale value #1795

merged 1 commit into from
Oct 5, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 5, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR makes sure any custom validate function is passing before sending stale cache value and revalidating in background

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1795 (273c47d) into main (0599ace) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   76.43%   76.10%   -0.33%     
==========================================
  Files          76       76              
  Lines        8007     8007              
  Branches      809      803       -6     
==========================================
- Hits         6120     6094      -26     
- Misses       1885     1911      +26     
  Partials        2        2

see 2 files with indirect coverage changes

@pi0 pi0 merged commit a03a18b into main Oct 5, 2023
9 checks passed
@pi0 pi0 deleted the fix/cache-validate branch October 5, 2023 17:43
@pi0 pi0 mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pi0